Match closing fence char and length in fenced code blocks #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for taking so long to review this and merge it in. Thank you for contributing this feature to Redcarpet! ❤️ |
|
@mattr- thanks for merging this! Is there a gem version release expected soon that incorporates this? Would you like me to start a PR for that? |
|
We'll handle the gem version bump and release from here. No ETA on when that might be though. If you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_codefence()now allows fence-pair matching to comply with https://spec.commonmark.org/0.29/#fenced-code-blockSo the following now works (as it does in GitHub, otherwise it would be difficult to type this :-))
Fixes #208.